Skip to content

chore: upgrade surfpool to v1.1.1 in CI#4190

Open
MicaiahReid wants to merge 9 commits intosolana-foundation:masterfrom
txtx:chore/surfpool-v1.0.0
Open

chore: upgrade surfpool to v1.1.1 in CI#4190
MicaiahReid wants to merge 9 commits intosolana-foundation:masterfrom
txtx:chore/surfpool-v1.0.0

Conversation

@MicaiahReid
Copy link
Copy Markdown
Contributor

@MicaiahReid MicaiahReid commented Jan 20, 2026

Fixes #4160

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 20, 2026

@MicaiahReid is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@MicaiahReid MicaiahReid force-pushed the chore/surfpool-v1.0.0 branch 3 times, most recently from 400325e to a162df5 Compare March 3, 2026 03:17
@MicaiahReid MicaiahReid changed the title chore: upgrade surfpool to v1.0.0 in CI chore: upgrade surfpool to v1.0.1 in CI Mar 3, 2026
@MicaiahReid MicaiahReid changed the title chore: upgrade surfpool to v1.0.1 in CI chore: upgrade surfpool to v1.1.0 in CI Mar 6, 2026
Copy link
Copy Markdown
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is infinitely better. Thanks for fixing!

Could you rebase to fix the conflicts from #4292?

@MicaiahReid MicaiahReid force-pushed the chore/surfpool-v1.0.0 branch from 6d431ef to bc92c65 Compare March 9, 2026 13:36
@MicaiahReid
Copy link
Copy Markdown
Contributor Author

This is infinitely better. Thanks for fixing!

Could you rebase to fix the conflicts from #4292?

Done!

Copy link
Copy Markdown
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI errors look legit:

  • bench: Is this coming from the upstream Solana/Agave deps? If not, what could be the reason of this change?

    1) Compute units
         "after all" hook for "UncheckedAccount":
       Error: Key 'accountEmptyInit1' has changed more than 1% but is not saved. Run `anchor test --skip-lint` in tests/bench and commit the changes.
    

    If this is intended, you can follow the steps mentioned in the last sentence of the output to fix the error.

  • misc:

    1) misc
         Can send VersionedTransaction:
       TransactionExpiredTimeoutError: Transaction was not confirmed in 30.00 seconds.
    
    2) misc
         Can fetch all accounts of a given type:
       TransactionExpiredTimeoutError: Transaction was not confirmed in 30.00 seconds.
    

@MicaiahReid
Copy link
Copy Markdown
Contributor Author

The CI errors look legit:

  • bench: Is this coming from the upstream Solana/Agave deps? If not, what could be the reason of this change?
    ...
  • misc:
    ...

Interesting. Both of these pass when I run locally against surfpool, so I figured they were flaky CI tests. Will investigate and let you know what I find.

@MicaiahReid MicaiahReid changed the title chore: upgrade surfpool to v1.1.0 in CI chore: upgrade surfpool to v1.1.1 in CI Mar 19, 2026
@MicaiahReid
Copy link
Copy Markdown
Contributor Author

@acheroncrypto I ran the bench CI against a previous version of surfpool that was still using solana v2.3 and the execution values matched with bench.json.

Current surfpool is on v3.1, so that explains the new CU performance.

One caveat here: previuosly the bench.json had one "solana_version" with a clear version, because (presumably) this was the version of solana-test-validator being run. Under the hood, surfpool is using the individual solana sdk components (solana-pubkey, solana-instruction, etc) so there is no clear "solana version". We could update this to reflect the surfpool version that was tested on to signify the change in bench metrics from being measured against the test validator to surfpool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install SURFPOOL_CLI_VERSION in CI

3 participants