chore: upgrade surfpool to v1.1.1 in CI#4190
chore: upgrade surfpool to v1.1.1 in CI#4190MicaiahReid wants to merge 9 commits intosolana-foundation:masterfrom
Conversation
|
@MicaiahReid is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
400325e to
a162df5
Compare
acheroncrypto
left a comment
There was a problem hiding this comment.
This is infinitely better. Thanks for fixing!
Could you rebase to fix the conflicts from #4292?
6d431ef to
bc92c65
Compare
Done! |
acheroncrypto
left a comment
There was a problem hiding this comment.
The CI errors look legit:
-
bench: Is this coming from the upstream Solana/Agave deps? If not, what could be the reason of this change?1) Compute units "after all" hook for "UncheckedAccount": Error: Key 'accountEmptyInit1' has changed more than 1% but is not saved. Run `anchor test --skip-lint` in tests/bench and commit the changes.If this is intended, you can follow the steps mentioned in the last sentence of the output to fix the error.
-
misc:1) misc Can send VersionedTransaction: TransactionExpiredTimeoutError: Transaction was not confirmed in 30.00 seconds. 2) misc Can fetch all accounts of a given type: TransactionExpiredTimeoutError: Transaction was not confirmed in 30.00 seconds.
Interesting. Both of these pass when I run locally against surfpool, so I figured they were flaky CI tests. Will investigate and let you know what I find. |
|
@acheroncrypto I ran the bench CI against a previous version of surfpool that was still using solana v2.3 and the execution values matched with bench.json. Current surfpool is on v3.1, so that explains the new CU performance. One caveat here: previuosly the bench.json had one "solana_version" with a clear version, because (presumably) this was the version of solana-test-validator being run. Under the hood, surfpool is using the individual solana sdk components ( |
Fixes #4160