feat(cli): Remove solana cli dependency#4099
feat(cli): Remove solana cli dependency#4099jacobcreech merged 17 commits intosolana-foundation:masterfrom
Conversation
…et configuration retrieval
…ding, and managing Solana programs
…pdating Anchor.toml settings
…roved error handling
|
@swaroop-osec is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
Just wanted to note that this was removed in #3877 as it's a very heavy dependency that brings in around 50 extra dependencies. Since we use just one function from this crate, is it possible to avoid adding the dependency? (Not a hard blocker, just preferable) |
…deployment and upgrade implementations
…or improved error handling
I tried removing it and deploying the program sequentially. It does reduce the binary size by approximately ~8.5%, but the deployment time becomes significantly longer. With this crate included, the same program deploys around 10× faster. For a better user experience—especially for large program deployments parallel deployment is much more beneficial, so we should keep the |
This should be fixable. Solana-client just uses the crates under the hood. |
jacobcreech
left a comment
jacobcreech
left a comment
There was a problem hiding this comment.
Going to pull this in but let's see if we can fix the deployment time removing solana-client before we tag the new version
github-project-automation
bot
moved this from Security Review Required
to Done
in Anchor 1.0
* feat: Address command to retrieve public key from wallet config * feat: Add Balance command * feat(cli): Added airdrop command * feat(cli): Add epoch and epoch info commands * refactor(cli): cargo fmt * feat(cli): Add support for transaction log streaming * feat(cli): improve WebSocket URL handling * feat(cli): add ShowAccount command to display account contents * feat(cli): implement keypair generation and management commands * feat(cli): enhance airdrop and balance commands with cluster and wallet configuration retrieval * feat(cli): introduce program management commands for deploying, upgrading, and managing Solana programs * feat(cli): add configuration management commands for retrieving and updating Anchor.toml settings * feat(cli): enhance log streaming with WebSocket subscriptions and improved error handling * docs(cli): clarify account struct deserialization format in Command enum * fix(cli): Fix workspace detection in various commands * refactor(cli): replace external Solana CLI calls with native program deployment and upgrade implementations * refactor(cli): update with_workspace function to return Result type for improved error handling
4 participants
Closes #3866
Based on #3963