feat-add: anchor cli balance#3939
Closed
dotslashapaar wants to merge 1 commit intosolana-foundation:masterfrom
Closed
feat-add: anchor cli balance#3939dotslashapaar wants to merge 1 commit intosolana-foundation:masterfrom
dotslashapaar wants to merge 1 commit intosolana-foundation:masterfrom
Conversation
|
@dotslashapaar is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
jamie-osec
reviewed
Oct 29, 2025
| .to_string_lossy() | ||
| .to_string() | ||
| }) | ||
| .unwrap_or_else(|| "~/.config/solana/id.json".to_string()); |
Collaborator
There was a problem hiding this comment.
~ will not be expanded by read_from_file, so this is unhelpful and should fail earlier
jamie-osec
reviewed
Oct 29, 2025
| #[clap(value_enum)] | ||
| shell: clap_complete::Shell, | ||
| }, | ||
| #[clap(name = "balance", alias = "balance")] |
Collaborator
There was a problem hiding this comment.
Suggested change
| #[clap(name = "balance", alias = "balance")] |
jamie-osec
reviewed
Oct 29, 2025
Comment on lines
+357
to
+358
| #[clap(index = 1, value_name = "ACCOUNT_ADDRESS")] | ||
| pubkey: Option<Pubkey>, |
Collaborator
There was a problem hiding this comment.
Suggested change
| #[clap(index = 1, value_name = "ACCOUNT_ADDRESS")] | |
| pubkey: Option<Pubkey>, | |
| #[clap(short, long] | |
| account: Option<Pubkey>, |
For consistency with other options
Collaborator
|
Actually sorry, closing in favour of #3963 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
anchor balancecommand to reduce Solana CLI dependency (#3866 )Adds native balance querying functionality to Anchor CLI, eliminating the need to shell out to
solana balance.Command also works outside the workspace