Remove rent exempt constraint

[jamie-osec]

Closes #2347

Rebased version of #2708

[vercel]

@acheroncrypto is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

[jacobcreech]

Could you rebase and rerun bench @swaroop-osec ?

[jamie-osec]

Pulled in @swaroop-osec's bench changes

[BretasArthur1]

Question, any existing code using #[account(rent_exempt = skip)] or #[account(rent_exempt = enforce)] will fail to compile? Since you removed those features... @jamie-osec

[jamie-osec]

As-is this will be a breaking change, yes. While this is for Anchor 1.0 iiuc (and therefore breakage is okay), we could mitigate this by parsing the attributes and only emitting a deprecation warning.

[BretasArthur1]

Sg!

[0x4ka5h]

@jamie-osec can you look at the failed tests once

[jamie-osec]

Spurious failure due to ratelimits. This will need rebasing for the benchmark changes though

[jamie-osec]

Given that this is breaking, I think we can just not port this when doing V2.