Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more token-2022 Examples #4

Merged
merged 7 commits into from
Mar 27, 2023

Conversation

shivamSspirit
Copy link
Contributor

@shivamSspirit shivamSspirit commented Mar 18, 2023

use token-2022 feature with Transfer Fees type extension

@buffalojoec
Copy link
Member

Ahh dang bro! @valentinmadrid just merged in some transfer fee token examples.

Any chance you can run a diff on your implementation vs. his? We can go with whichever one is more descriptive

@valentinmadrid
Copy link
Collaborator

You could add the withdraw_withheld_tokens_from_accounts instruction to the example.

@shivamSspirit
Copy link
Contributor Author

Ahh dang bro! @valentinmadrid just merged in some transfer fee token examples.

Any chance you can run a diff on your implementation vs. his? We can go with whichever one is more descriptive

I think you merged the valentinmadrid example no issues now I work on a different example

@shivamSspirit
Copy link
Contributor Author

You could add the withdraw_withheld_tokens_from_accounts instruction to the example.

yes i will work on this withdraw_withheld_tokens_from_accounts

@buffalojoec
Copy link
Member

Please remove the transfer fee example from your PR and rename the folder for "Reallocating Space" to contain the proper spelling of "reallocate"

@buffalojoec
Copy link
Member

Looks like you've still got the old "relocate" directory in there, and I also noticed you mis-spelled "account" in one of the other directories. Plus, I still see transfer fee.

@shivamSspirit
Copy link
Contributor Author

I will look into this

@shivamSspirit shivamSspirit changed the title add transfer-fee-token-example Add more token-2022 Examples Mar 25, 2023
@shivamSspirit
Copy link
Contributor Author

I think I removed those examples that are preexisted

see here: https://github.com/shivamsoni00/web3-examples/tree/newtoken2022/tokens/token-2022

@buffalojoec buffalojoec merged commit 951a345 into solana-developers:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants