Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add value validation to header #270

Merged
merged 5 commits into from
Jun 22, 2023
Merged

Add value validation to header #270

merged 5 commits into from
Jun 22, 2023

Conversation

wydra98
Copy link
Contributor

@wydra98 wydra98 commented Jun 18, 2023

No description provided.

@wydra98 wydra98 requested a review from adamw June 18, 2023 22:00
@wydra98 wydra98 linked an issue Jun 19, 2023 that may be closed by this pull request
No way to handle Invalid header value using HttpClientZioBackend softwaremill/sttp#1823
Closed
@wydra98 wydra98 requested a review from adamw June 20, 2023 15:35
@wydra98 wydra98 requested a review from adamw June 21, 2023 07:23
adamw
adamw approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@adamw adamw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the two minor comments are resolved, let's release as 1.6 (next minor release). Thanks!

@wydra98 wydra98 merged commit a36bf45 into master Jun 22, 2023
@mergify mergify bot deleted the add-value-validation-to-header branch June 22, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamw adamw adamw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No way to handle Invalid header value using HttpClientZioBackend
2 participants
@wydra98 @adamw