Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TooEarly StatusCode (425) to StatusCodes trait #251

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

domdorn
Copy link
Contributor

@domdorn domdorn commented Mar 2, 2023

@adamw
Copy link
Member

adamw commented Mar 2, 2023

Unfortunately adding a field to a trait isn't bin-compatible. Adding a def, though (w/ a comment that it's because of bin compat), should be fine. Not ideal, but better than nothing.

@domdorn
Copy link
Contributor Author

domdorn commented Mar 2, 2023

hmm.. i just did it the same way like the others.. should I change it to a def?

@adamw
Copy link
Member

adamw commented Mar 3, 2023

Yes, but the others were part of the original release, and adding new fields is not possible due to binary compatibity requirements.

@domdorn
Copy link
Contributor Author

domdorn commented Mar 6, 2023

updated!

@adamw
Copy link
Member

adamw commented Mar 7, 2023

Sigh ... scala 2.11 ... we'll be dropping 2.11 soon so I'll merge this PR then. Sorry :)

@adamw
Copy link
Member

adamw commented Jul 12, 2023

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

rebase

✅ Branch has been successfully rebased

@adamw adamw merged commit aa4edf9 into softwaremill:master Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants