"Instant" format according to rfc1123-date1 #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braginxv
changed the title
adamw
reviewed
Dec 31, 2022
| @@ -165,5 +165,8 @@ object Header { | |||
| } | |||
| def unsafeParseHttpDate(s: String): Instant = parseHttpDate(s).getOrThrow | |||
|
|
|||
| def toHttpDateString(i: Instant): String = DateTimeFormatter.RFC_1123_DATE_TIME.format(i.atZone(GMT)) | |||
| def toHttpDateString(instantTime: Instant): String = { | |||
| val pattern = DateTimeFormatter.ofPattern("EEE, dd LLL YYYY HH:mm:ss", Locale.US) | |||
There was a problem hiding this comment.
maybe this can be a private constant, to avoid re-parsing the format every time?
braginxv
force-pushed
the
braginxv
branch
2 times, most recently
from
37536de to
b893179
Compare
|
fixes done |
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make http4s able to parse datetime values, the formatting of these values has to be done according to rfc1123-date1 with a leading zero for single-digit dates