Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added HttpVersion model #232

Merged
merged 2 commits into from
Nov 13, 2022
Merged

Added HttpVersion model #232

merged 2 commits into from
Nov 13, 2022

Conversation

Pask423
Copy link
Contributor

@Pask423 Pask423 commented Nov 12, 2022

No description provided.

@Pask423 Pask423 self-assigned this Nov 12, 2022
@Pask423 Pask423 requested a review from adamw November 12, 2022 20:34
adamw
adamw reviewed Nov 13, 2022
View reviewed changes
core/src/main/scala/sttp/model/HttpVersion.scala Outdated

sealed trait HttpVersion
object HttpVersion {
case object Default extends HttpVersion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that maybe as an enum, the HttpVersion shouldn't include Default. On the sttp-client side, we can use an optional. We might include HTTP_3 for the future, though ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Pask423 Pask423 merged commit 1c72561 into master Nov 13, 2022
@mergify mergify bot deleted the feature/http-version branch November 13, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamw adamw adamw approved these changes

Assignees

@Pask423 Pask423

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pask423 @adamw