Added map with status texts #214
Conversation
| @@ -2,6 +2,7 @@ package sttp.model | |||
|
|
|||
| import internal.Validate._ | |||
|
|
|||
| // TODO: When moving to v2 add status text as field | |||
There was a problem hiding this comment.
well this models a status code, why would it include a status text? :)
There was a problem hiding this comment.
As if I think correctly status text is to a degree part of status code as it should be same as name of status code https://developer.mozilla.org/en-US/docs/Web/API/Response/statusText
There was a problem hiding this comment.
To me it looks as if it's a different property on a Response class, which can be usually calculated from the status code, but definitely not part of it
| NetworkAuthenticationRequired -> "Network Authentication Required" | ||
| ) | ||
|
|
||
| def get(statusCode: StatusCode): String = |
There was a problem hiding this comment.
I think it would be better to return an Option ale let the user decide what to do if it's a non-standard status code.
Are these texts "default" descriptions, that is, might they differ in actual server responses? Why would need this map in the first place? :)
There was a problem hiding this comment.
1 OK
2 Yes I intend to use it as default.
In sttp core in Response class we allow to set status text as in the screen.
I would like to write method, in sttp core, that will use one of these texts if sttp user does not provide one
There was a problem hiding this comment.
Ok, so maybe let's call this method StatusTexts.default(StatusCode)?
|
Thanks :) |
Base for softwaremill/sttp#1451. I would like to add set of status text here and use them in sttp core
Response.