Implement AWS JSON protocol 1.0 #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katlasik
force-pushed
the
issue-812-wip
branch
5 times, most recently
from
7a25ce4 to
87cf644
Compare
adamw
reviewed
May 16, 2023
rest/rest-sqs/src/main/scala/org/elasticmq/rest/sqs/CreateQueueDirectives.scala
Outdated
Show resolved
Hide resolved
katlasik
force-pushed
the
issue-812-wip
branch
6 times, most recently
from
96c5619 to
2f872a4
Compare
Co-authored-by: Adam Fish Rybicki <[email protected]>
|
Refactoring with AkkaSupport trait
|
adamw
reviewed
May 29, 2023
rest/rest-sqs/src/main/scala/org/elasticmq/rest/sqs/AkkaSupport.scala
Outdated
Show resolved
Hide resolved
adamw
reviewed
May 29, 2023
rest/rest-sqs/src/main/scala/org/elasticmq/rest/sqs/AkkaSupport.scala
Outdated
Show resolved
Hide resolved
adamw
reviewed
May 29, 2023
rest/rest-sqs/src/main/scala/org/elasticmq/rest/sqs/AkkaSupport.scala
Outdated
Show resolved
Hide resolved
adamw
reviewed
May 29, 2023
rest/rest-sqs/src/main/scala/org/elasticmq/rest/sqs/QueueAttributesDirectives.scala
Show resolved
Hide resolved
adamw
reviewed
May 29, 2023
rest/rest-sqs/src/main/scala/org/elasticmq/rest/sqs/QueueAttributesDirectives.scala
Outdated
Show resolved
Hide resolved
adamw
reviewed
May 29, 2023
rest/rest-sqs/src/main/scala/org/elasticmq/rest/sqs/XmlSerializer.scala
Outdated
Show resolved
Hide resolved
adamw
reviewed
May 29, 2023
| extractRequest { request => | ||
| entityOrEmpty { fd => | ||
| body((fd.fields.toMap ++ queryParameters ++ extractAwsXRayTracingHeader(request)).filter(_._1 != "")) | ||
| private def extractQueueNameAndUrlFromRequest(body: Map[String, String] => Route): Route = { |
There was a problem hiding this comment.
[minor] this looks like a Directive ;)
There was a problem hiding this comment.
Do you mean I should move it somewhere?
There was a problem hiding this comment.
no, the method should be a directive. Sth like extractQueueNameAndUrlFromRequest(Map): Directive0, no?
|
I left some comments, looks good overall :) What about testing? Will it be possible to test both the XML and JSON interfaces? And also ... @micossow maybe you could take a look as well? You're probably most up-to-date with EMQ :) |
katlasik
commented
May 29, 2023
rest/rest-sqs/src/main/scala/org/elasticmq/rest/sqs/directives/AWSProtocolDirectives.scala
Show resolved
Hide resolved
|
closes #812 |
added 2 commits
May 31, 2023 08:39
* Added integration tests for CLI * Added integration tests for CLI * send single message tests * interpolation in strings * Add test for tagging, adding permissions and for invalid input * Added test for purge queue * delete queue wip * receive messages test * send message batch tests * delete message test * Add tests for visibility timeout * delete message batch wip * Tests for set and get attribute names * Add case keyword for inside blocks * Skip some tests for 2.12 --------- Co-authored-by: Adam Fish Rybicki <[email protected]>
micossow
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement AMZ Json Protocol 1.0.
- [ ] (optional) Customize serialization (use camelCase in case classes and respond with PascalCase)- [ ] Add ListDeadLetterSourceQueues Actionhttps://docs.aws.amazon.com/AWSSimpleQueueService/latest/APIReference/API_ListDeadLetterSourceQueues.html- [ ] Add RemovePermission Actionhttps://docs.aws.amazon.com/AWSSimpleQueueService/latest/APIReference/API_RemovePermission.html