Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add older macos sdk targets for crypto-cpp-py #411

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

THenry14
Copy link
Member

Please check if the PR fulfills these requirements

  • The formatter, linter, and tests all run without an error
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Crypto-cpp-py no longer needs compiling for older mac m1 targets

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 96.49% // Head: 96.49% // No change to project coverage 👍

Coverage data is based on head (0f7fca6) compared to base (22eeb6a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #411   +/-   ##
============================================
  Coverage        96.49%   96.49%           
============================================
  Files               43       43           
  Lines             2166     2166           
============================================
  Hits              2090     2090           
  Misses              76       76           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@war-in war-in merged commit 4e0c684 into development Sep 30, 2022
@war-in war-in deleted the szymczyk/mac-m1-targets branch September 30, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants