Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable deploying contracts without providing abi #1452

Merged
merged 101 commits into from
Aug 29, 2024
Merged

Enable deploying contracts without providing abi #1452

merged 101 commits into from
Aug 29, 2024

Conversation

kkawula
Copy link
Collaborator

@kkawula kkawula commented Aug 22, 2024 •
edited
Loading

Relates #1409

Introduced changes

  • Made abi parameter in Contract.deploy_contract_v3 optional

  • This PR contains breaking changes

@kkawula
Merge branch 'kkawula/1334-remove-unnecessary-cairo-0-tests'
dd83220
@kkawula
Migrate tests to use cairo 1 ERC20 contract
7009e4f
@kkawula
Remove ERC20 contract cairo code and fixtures
9c1e645
@kkawula
Adapt tests to the cairo 1
9a01051
@kkawula
Merge 'development'
966f950
@kkawula
Merge 'development'
8c4418f
@kkawula
Fix test in Serilization Guide
f43673a
@kkawula
Fix typo in 'test_abi_parsing'
3b1658c
@kkawula
Fix after merge
2adc084
@kkawula
Remove 'constructor_with_arguments.cairo' and 'constructor_without_ar…
82e7242 
…guments.cairo' contracts
@kkawula
Add 'constructor_with_arguments.cairo' contract and update test_throw…
301a8d4 
…s_when_calldata_not_provided
@kkawula
Update 'test_constructor_arguments_contract_deploy'
74e9360
@kkawula
Add skiping test while cairo v1 test dir is triggered
50bad80
@kkawula
Update 'test_create_deployment_call_raw_supports_seed_0' and 'test_cr…
46f4e6e 
…eate_deployment_call_raw'
@kkawula
Remove old 'constructor_with_arguments' fixture
ad05ad8
@kkawula
Update 'test_deploying_with_udc'
a0db46f
@kkawula
Update 'constructor_with_arguments_abi' and 'constructor_with_argumen…
c735a0d 
…ts_class_hash' fixture
@kkawula
Update docs example
02c1647
@kkawula
Add 'map' contract implementation in cairo 1
c7152f2
@kkawula
Add fixtures for new contract
e1dceb2
@kkawula
Remove 'map_contract_declare_hahs' fixutre
518eafa
@kkawula
Replace old 'map_contract' fixture
a1c69b4
@kkawula
Replace old 'map_class_hash' fixture
e5d6b71
@kkawula
Update a few tests
964a289
@kkawula
Update 'test_deploying_in_multicall'
a7d664c
@kkawula
Remove 'Simple declare and deploy' paragraph from docs
2b8520b
@kkawula
Update docs example 'Quickstart - Using Account'
bf0be0d
@kkawula
Update docs example 'Guide - test_simple_deploy
dc814a2
@kkawula
Remove fixtures 'map_source_code' and 'map_compiled_contract'
8e9b904
@kkawula
Fix PriceUnit assertion in 'test_account_estimate_fee_for_declare_tra…
44fb7c2 
…nsaction'
@codecov Codecov
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (kkawula/remove-sign-declare-v1@1f1f120). Learn more about missing BASE report.

Files Patch % Lines
starknet_py/net/udc_deployer/deployer.py 81.81% 2 Missing ⚠️
starknet_py/contract.py 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@                        Coverage Diff                        @@
##             kkawula/remove-sign-declare-v1    #1452   +/-   ##
=================================================================
  Coverage                                  ?   93.36%           
=================================================================
  Files                                     ?      106           
  Lines                                     ?     5490           
  Branches                                  ?        0           
=================================================================
  Hits                                      ?     5126           
  Misses                                    ?      364           
  Partials                                  ?        0
Files Coverage Δ
starknet_py/contract.py 95.48% <66.66%> (ø)
starknet_py/net/udc_deployer/deployer.py 96.07% <81.81%> (ø)

@kkawula kkawula marked this pull request as ready for review August 23, 2024 09:34
franciszekjob
franciszekjob reviewed Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@franciszekjob franciszekjob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

starknet_py/net/udc_deployer/deployer.py Outdated Show resolved Hide resolved
starknet_py/tests/e2e/docs/code_examples/test_contract.py Outdated Show resolved Hide resolved
franciszekjob
franciszekjob reviewed Aug 28, 2024
View reviewed changes
starknet_py/tests/e2e/deploy/deployer_test.py Outdated Show resolved Hide resolved
starknet_py/net/udc_deployer/deployer.py Outdated Show resolved Hide resolved
starknet_py/net/udc_deployer/deployer.py Outdated Show resolved Hide resolved
starknet_py/tests/e2e/deploy/deployer_test.py Outdated Show resolved Hide resolved
Base automatically changed from kkawula/remove-sign-declare-v1 to development August 29, 2024 08:36
@kkawula
Merge branch 'development' into kkawula/enable-contract-deploy-withou…
781ea0b 
…t-providing-abi

 Conflicts:
	starknet_py/abi/v0/parser_test.py
	starknet_py/abi/v0/schemas_test.py
	starknet_py/serialization/serialization_test.py
	starknet_py/tests/e2e/account/account_test.py
	starknet_py/tests/e2e/block_test.py
@kkawula
Add empty line for readability
54f0f92
@kkawula
Fix after merge
b315707
franciszekjob
franciszekjob approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@franciszekjob franciszekjob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkawula kkawula merged commit 35845a2 into development Aug 29, 2024
16 checks passed
@kkawula kkawula deleted the kkawula/enable-contract-deploy-without-providing-abi branch August 29, 2024 10:13
@franciszekjob franciszekjob mentioned this pull request Sep 2, 2024
Merged
1 task
@franciszekjob franciszekjob mentioned this pull request Sep 12, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciszekjob franciszekjob franciszekjob approved these changes

Assignees

@kkawula kkawula

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkawula @franciszekjob