Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add estimate_fee to Account #1279

Merged
merged 18 commits into from
Feb 15, 2024
Merged

Add estimate_fee to Account #1279

merged 18 commits into from
Feb 15, 2024

Conversation

tkumor3
Copy link
Contributor

@tkumor3 tkumor3 commented Feb 6, 2024 •
edited
Loading

Closes #1287

Introduced changes

  • This PR contains breaking changes

@codecov Codecov
Copy link

codecov bot commented Feb 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0dcf387) 97.99% compared to head (8ff1269) 97.99%.

Additional details and impacted files 
@@             Coverage Diff              @@
##           development    #1279   +/-   ##
============================================
  Coverage        97.99%   97.99%           
============================================
  Files               90       90           
  Lines             4595     4597    +2     
============================================
+ Hits              4503     4505    +2     
  Misses              92       92
Files Coverage Δ
starknet_py/net/account/account.py 99.59% <100.00%> (ø)
starknet_py/net/account/base_account.py 100.00% <100.00%> (ø)

ddoktorski
ddoktorski requested changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@ddoktorski ddoktorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed that some of the previous comments I made have not been completely addressed yet. Please check it and request a review again once it's ready.

@tkumor3 tkumor3 force-pushed the tomaszkumor/add_estimate_fee_to_account branch from 62d9b98 to 0c0c413 Compare February 9, 2024 12:57
@tkumor3 tkumor3 force-pushed the tomaszkumor/add_estimate_fee_to_account branch from 0c0c413 to 4d77438 Compare February 9, 2024 12:59
ddoktorski
ddoktorski approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@ddoktorski ddoktorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to include this change in the guide in our documentation. Given that there are some fee estimation related changes in the next Starknet 0.13.1 version, it can be done in a separate PR.

@tkumor3 tkumor3 mentioned this pull request Feb 9, 2024
Closed
@tkumor3 tkumor3 merged commit f992bc8 into development Feb 15, 2024
16 checks passed
@tkumor3 tkumor3 deleted the tomaszkumor/add_estimate_fee_to_account branch February 16, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddoktorski ddoktorski ddoktorski approved these changes

Assignees

@tkumor3 tkumor3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add estimate_fee to Account
2 participants
@tkumor3 @ddoktorski