Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update github actions versions #1504

Closed
wants to merge 5 commits into from
Closed

fix: Update github actions versions #1504

wants to merge 5 commits into from

Conversation

raizo07
Copy link

@raizo07 raizo07 commented Oct 2, 2024 •
edited
Loading

Closes 1320

Introduced changes

Update github actions versions

@raizo07 raizo07 marked this pull request as draft October 2, 2024 10:50
@codecov Codecov
Copy link

codecov bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.94%. Comparing base (2a84190) to head (44a4b6c).

Additional details and impacted files 
@@               Coverage Diff                @@
##           development    #1504       +/-   ##
================================================
+ Coverage        81.44%   92.94%   +11.50%     
================================================
  Files               96      107       +11     
  Lines             5190     5558      +368     
================================================
+ Hits              4227     5166      +939     
+ Misses             963      392      -571

see 68 files with indirect coverage changes

@raizo07 raizo07 marked this pull request as ready for review October 2, 2024 12:42
@raizo07
Copy link
Author

raizo07 commented Oct 3, 2024

@franciszekjob Kindly review.

@raizo07
Copy link
Author

raizo07 commented Oct 8, 2024

@franciszekjob any update on this?

franciszekjob
franciszekjob requested changes Oct 8, 2024
View reviewed changes
.github/workflows/checks.yml Outdated Show resolved Hide resolved
@raizo07
Copy link
Author

raizo07 commented Oct 9, 2024

@franciszekjob Updated, Kindly review.

@raizo07
Copy link
Author

raizo07 commented Oct 11, 2024

@franciszekjob any update on this?

franciszekjob
franciszekjob requested changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@franciszekjob franciszekjob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good to go, please:

  1. Remove formatting-related changes
  2. Remove string literal changes, e.g. there's no need to change 'pip' to "pip"

.github/workflows/checks.yml
Comment on lines +240 to +242
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this token needed here? I assume that v3 did not require it and v4 does?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes V4 does, previously it was not needed for public repos in V3, but for v4 it is needed for both public and private repos @franciszekjob

.github/workflows/checks.yml Outdated Show resolved Hide resolved
.github/workflows/checks.yml Outdated Show resolved Hide resolved
.github/workflows/checks.yml Outdated Show resolved Hide resolved
.github/workflows/checks.yml Outdated Show resolved Hide resolved
.github/workflows/checks.yml Outdated Show resolved Hide resolved
.github/workflows/checks.yml Outdated Show resolved Hide resolved
@franciszekjob
Copy link
Collaborator

@raizo07 just reviewed 👍

@raizo07
Copy link
Author

raizo07 commented Oct 14, 2024

@franciszekjob Kindly review

@franciszekjob
Copy link
Collaborator

@raizo07 you didn't apply changes I mentioned in previous comment

@franciszekjob
Copy link
Collaborator

Hi @raizo07, I'm sorry but I need to close this PR as you didn't apply changes I requested.

@raizo07 raizo07 deleted the github-actions branch November 12, 2024 09:48
@raizo07 raizo07 restored the github-actions branch November 12, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciszekjob franciszekjob Awaiting requested review from franciszekjob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update github actions versions
2 participants
@raizo07 @franciszekjob