Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github actions versions #1320

Open
tkumor3 opened this issue Mar 11, 2024 · 14 comments
Open

Update github actions versions #1320

tkumor3 opened this issue Mar 11, 2024 · 14 comments
Assignees
Labels

Comments

@tkumor3
Copy link
Contributor

tkumor3 commented Mar 11, 2024

There are few warnings (see them eg. here under "Annotations" section) related with github actions which use deprecared Node.js versions. Some actions' versions need to be updated.
image

Copy link
Contributor

This issue is stale because it has not received any activity in the last 30 days. Remove stale label or add a comment, otherwise it will be closed in 5 days.

@GoSTEAN
Copy link

GoSTEAN commented Aug 26, 2024

hi

@franciszekjob franciszekjob added the good first issue Good for newcomers label Aug 27, 2024
@franciszekjob franciszekjob changed the title Update node version on github action Update github actions versions Aug 27, 2024
@franciszekjob
Copy link
Collaborator

Hi @GoSTEAN, would you like to handle this issue?

@KevinMB0220
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I have experience in all the languages ​​used in the issue, so it would be easier for me to achieve it.

How I plan on tackling this issue

Having experience in programming, I can easily detect errors in the code and program the issue in compliance with programming standards.

@GoSTEAN
Copy link

GoSTEAN commented Aug 28, 2024

@franciszekjob Yes I'd love to handle this issue. Thank you

@franciszekjob
Copy link
Collaborator

@KevinMB0220
Currently, we do not sponsor this issue nor any other issues through OnlyDust.

@GoSTEAN
Copy link

GoSTEAN commented Aug 28, 2024

@franciszekjob I have started working on it already. Thank you

@raizo07
Copy link

raizo07 commented Sep 24, 2024

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

@tkumor3 Hello, I like to work on this.

Here is my Onlydust profile https://app.onlydust.com/u/raizo07

Copy link

onlydustapp bot commented Sep 24, 2024

Hey @raizo07!
Thanks for showing interest.
We've created an application for you to contribute to Starknet SDK for Python.
Go check it out on OnlyDust!

Copy link

onlydustapp bot commented Sep 24, 2024

Hey @raizo07!
Thanks for showing interest.
We've created an application for you to contribute to starknet.py.
Go check it out on OnlyDust!

@georgegoldman
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I have over 5 years of experience as a software engineer, specializing in backend development, DevOps, and automation tools. I have worked extensively with continuous integration and deployment systems, particularly GitHub Actions, Docker, and Kubernetes, in various projects. My focus has often been on optimizing development workflows, automating testing, and ensuring the reliability of code deployments.
In my recent projects, I’ve been responsible for maintaining and updating CI/CD pipelines, ensuring they run smoothly with the latest versions of dependencies and tools. I’ve also contributed to open-source projects by improving their GitHub Actions workflows, fixing issues with deprecated versions of Node.js, and optimizing performance by introducing newer actions.
My experience with GitHub Actions, particularly in updating workflows and dealing with version deprecations, directly aligns with the task at hand for OnlyDust. I can help ensure that the CI/CD pipelines are up to date, eliminate the warnings related to outdated Node.js versions, and improve the overall efficiency of your development workflow. I’m confident that my background in automation and DevOps can be leveraged to enhance the performance and reliability of your infrastructure.
I’m excited about the possibility of contributing to OnlyDust’s mission by improving your development processes. I believe my skills in DevOps and CI/CD pipeline management will allow me to make a meaningful impact on the team.

How I plan on tackling this issue

  1. Understand the Scope of the Problem
    The problem involves GitHub Actions workflows in the project using deprecated versions of Node.js, resulting in warnings.
    The task is to identify the workflows, actions, or steps that are impacted and update them to use the latest supported versions of Node.js.
  2. Locate the GitHub Actions Workflows
    First, I would navigate to the .github/workflows/ directory of the repository. This is where GitHub Actions workflows are typically defined as YAML files.
  3. Identify Deprecated Actions
    I would look through the logs in GitHub Actions runs (under the “Annotations” section as mentioned) to see which actions or steps trigger the deprecation warnings.
    Focus on actions such as setup-node or any other workflows that specifically depend on Node.js. For example, it might be actions/setup-node@v1 or node-version: '12.x' which could be triggering the warnings due to outdated versions.
  4. Update the GitHub Actions Versions
    I would update the specific GitHub Actions and versions that use deprecated Node.js, such as:
    actions/setup-node to the latest version (v3 or another version as per the latest stable release).
    Update the node-version to a more current LTS version of Node.js (e.g., 16 or 18, depending on the compatibility of the project).
  5. Verify Other Dependencies
    I would check if there are any other actions, tools, or libraries in the workflows that rely on specific Node.js versions. If these tools are also affected by Node.js version deprecation, I would make appropriate updates.
    This could include ensuring that any Node.js-based build, test, or deployment steps still work with the updated versions of Node.js.
  6. Run Tests and Validate the Updates
    After making the updates, I would trigger the GitHub Actions workflows to run, either through a push to a separate branch or using a tool like act to run them locally.
    I would monitor the GitHub Actions run to ensure that:
    The deprecation warnings are gone.
    The workflows complete successfully without any new errors introduced by the Node.js version changes.
    If needed, I would debug any issues or rollback changes until the workflows are stable.
  7. Document the Changes
    Once the updates are verified, I would document what was changed, why it was changed, and how it benefits the project. This documentation can be part of the pull request description, ensuring the maintainers understand the updates clearly.
  8. Submit the Pull Request
    Finally, I would submit the pull request with a clear title, such as "Update GitHub Actions to Resolve Node.js Deprecation Warnings". The description would outline the specific changes, such as:
    Updated actions/setup-node from v1 to v3.
    Updated Node.js version from 12.x to 16.x (or another LTS version).
    Verified that all workflows pass successfully without warnings or errors.
    Potential Challenges:
    Dependency Compatibility: Some tools in the workflows may rely on specific versions of Node.js, and updating the version could cause issues. I would need to check compatibility and potentially update other dependencies or pin versions that still work.
    Workflow Complexity: Some workflows might have custom scripts or dependencies that are tightly coupled to a specific Node.js version. Testing and troubleshooting would be essential to ensure smooth updates.

@WankioM
Copy link

WankioM commented Sep 25, 2024

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I have a background in Node.js and Python, with experience in blockchain tech, Ethereum, and Solidity. I’ve worked with The Graph for querying blockchain data, which complements my skills in TypeScript.

How I plan on tackling this issue

This looks like a nodejs problem . it can be correcting by specifying the lates version of node on yaml in github actions eg:
node-version: '22.x'

@Ndifreke000
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I have solid Python skills and a lot of experience in blockchain development. I’ve worked on projects where I built Python tools and decentralized apps, mainly focusing on integrating smart contracts and designing APIs. In one of my recent projects, I created a system that automated revenue sharing through smart contracts, making sure everything worked smoothly and efficiently. These experiences give me the hands-on knowledge needed to tackle challenges like those in StarkNet.

How I plan on tackling this issue

I would audit the current API structure, using Python to build automated tests to identify inconsistencies in RPC schemes and model names. I’d propose naming conventions aligned with StarkNet and collaborate with the community to implement changes incrementally. To ensure accuracy, I’d create unit tests and documentation for the new API models, establishing a framework for future updates

@franciszekjob
Copy link
Collaborator

@raizo07 I've assigned you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants