Skip to content

feat: Set compile options using target_compile_reactnative_options #2710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2025
Merged

feat: Set compile options using target_compile_reactnative_options #2710

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
205af7b
feat: Set compile options using `target_compile_reactnative_options`
jakex7 Jul 14, 2025
1f56cd2
Add trailing line
jakex7 Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 21 additions & 20 deletions android/src/main/jni/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,6 @@ string(
CMAKE_CXX_FLAGS
" -DREACT_NATIVE_MINOR_VERSION=${ReactAndroid_VERSION_MINOR}")

add_compile_options(
-fexceptions
-frtti
-std=c++20
-Wall
-Wpedantic
-Wno-gnu-zero-variadic-macro-arguments
-Wno-dollar-in-identifier-extension
)

file(GLOB rnsvg_SRCS CONFIGURE_DEPENDS *.cpp ${RNS_COMMON_DIR}/react/renderer/components/rnsvg/*.cpp)
file(GLOB rnsvg_codegen_SRCS CONFIGURE_DEPENDS ${RNS_GENERATED_REACT_DIR}/*cpp)

Expand Down Expand Up @@ -76,18 +66,29 @@ target_link_libraries(
fbjni
)

target_compile_options(
react_codegen_rnsvg
PRIVATE
-DLOG_TAG=\"ReactNative\"
-fexceptions
-frtti
-std=c++20
-Wall
)

target_include_directories(
${CMAKE_PROJECT_NAME}
PUBLIC
${CMAKE_CURRENT_SOURCE_DIR}
)

if(ReactAndroid_VERSION_MINOR GREATER_EQUAL 80)
target_compile_reactnative_options(react_codegen_rnsvg PUBLIC)
else()
target_compile_options(
react_codegen_rnsvg
PRIVATE
-fexceptions
-frtti
-std=c++20
-Wall
)
endif()

target_compile_options(
react_codegen_rnsvg
PRIVATE
-Wpedantic
-Wno-gnu-zero-variadic-macro-arguments
-Wno-dollar-in-identifier-extension
)
Loading