feat: custom shadow nodes #2568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-piasecki
reviewed
Dec 6, 2024
common/cpp/react/renderer/components/rnsvg/RNSVGConcreteShadowNode.h
Outdated
Show resolved
Hide resolved
common/cpp/react/renderer/components/rnsvg/RNSVGLayoutableShadowNode.cpp
Show resolved
Hide resolved
common/cpp/react/renderer/components/rnsvg/RNSVGLayoutableShadowNode.cpp
Show resolved
Hide resolved
common/cpp/react/renderer/components/rnsvg/RNSVGLayoutableShadowNode.cpp
Show resolved
Hide resolved
j-piasecki
approved these changes
Dec 6, 2024
common/cpp/react/renderer/components/rnsvg/RNSVGLayoutableShadowNode.cpp
Outdated
Show resolved
Hide resolved
common/cpp/react/renderer/components/rnsvg/RNSVGLayoutableShadowNode.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Jakub Piasecki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement custom shadow nodes for nearly all
Svgcomponents. While it's a foundation for numerous upcoming changes, it currently addresses and resolves #2544.Test Plan
There shouldn't be any noticeable changes, and everything should function as before, except that
onLayoutwill now be triggered only once and with the correct dimensions.Compatibility