Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: color shift in FeColorMatrix on android #2365

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

jakex7
Copy link
Member

@jakex7 jakex7 commented Jul 24, 2024

Summary

While debugging #2364 I've noticed that color shift in FeColorMatrix on Android is wrong.
On web, elements 5, 10, 15, 20 is a color shift represented by number where 1 mean full color shift, while on Android it's 255 for full color shift.

Test

<svg width="180" height="180" viewBox="0 0 180 180">
  <rect width="180" height="180" fill="red" filter="url(#filter)"/>
  <filter id="filter">
    <feColorMatrix type="matrix" values="0 0 0 0 1
                                         0 1 0 0 0
                                         0 0 1 0 0
                                         0 0 0 1 0"/>
  </filter>
</svg>

@jakex7 jakex7 merged commit 9a2cd3d into main Jul 24, 2024
3 checks passed
@jakex7 jakex7 deleted the @jakex7/fixFeColorMatrixShiftAndroid branch July 24, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant