Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve windows ci job #2329

Merged
merged 3 commits into from
Jul 12, 2024
Merged

feat: improve windows ci job #2329

merged 3 commits into from
Jul 12, 2024

Conversation

marlenecota
Copy link
Contributor

@marlenecota marlenecota commented Jul 3, 2024 •
edited
Loading

Summary

Improves the windows build time.

Test Plan

Before:
image

After:
image

Compatibility

OS Implemented
iOS ❌
Android ❌
Windows ✅

Checklist

  • I have tested this on a device and a simulator
  • I added documentation in README.md
  • I updated the typed files (typescript)
  • I added a test for the API in the __tests__ folder

@marlenecota marlenecota marked this pull request as ready for review July 9, 2024 02:58
WoLewicki
WoLewicki approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@WoLewicki WoLewicki merged commit 3b360a2 into software-mansion:main Jul 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WoLewicki WoLewicki WoLewicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marlenecota @WoLewicki