feat: SvgFromUri/SvgFromXml add props onError execution #2132
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
onError
function of theSvgFromUri
/SvgFromXml
component does not work.According to the current code, there is no way to track if an error occurs in the component rendering.
Test Plan
What's required for testing (prerequisites)?
uri
fetch fails.What are the steps to reproduce (after prerequisites)?
Pass the
onError
function as props to test whether it is executed.Compatibility
Checklist
README.md
__tests__
folder