Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace org.jetbrains.annotations with androidx #1855

Closed

Conversation

dpott197
Copy link

@dpott197 dpott197 commented Sep 4, 2022

Resolves #1854

@muhammadtaha1998
Copy link

muhammadtaha1998 commented Sep 4, 2022

Also need to change this.

node_modules/react-native-svg/android/src/paper/java/com/horcrux/svg/FabricEnabledViewGroup.java

import org.jetbrains.annotations.Nullable;

with

import androidx.annotation.Nullable;

@dpott197
Copy link
Author

dpott197 commented Sep 4, 2022

@muhammadtaha1998 Thanks for looking at this! I really do appreciate it. node_modules/react-native-svg/android/src/paper/java/com/horcrux/svg/FabricEnabledViewGroup.java should be replaced automatically. If you are testing this locally and you are having issues, it may make sense to remove rm -rf node_modules and try again.

@WoLewicki
Copy link
Member

Since #1851 has been merged and I believe we do not need FabricEnabledViewGroup at all I will close this PR. Thanks for your contribution!

@WoLewicki WoLewicki closed this Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please replace org.jetbrains.annotations with androidx.annotation
3 participants