Change enum declaration in index.d.ts to UnionType
#1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
WoLewicki
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1210
This PR is in addition to #1559 by @avery-pierce .
As #1559 (comment) commented, it should be better to remove all enum from
index.d.ts,MarkerUnitsandOrient.Because these did not have an already defined UnionType like MaskUnit, we created a new one.
Test Plan
This PR doesn't affect any executable code.
This correspondence only changes
index.d.tsand its accompanying index.js.flow.What's required for testing (prerequisites)?
None
What are the steps to reproduce (after prerequisites)?
None
Compatibility
Only changes the Typescript declaration
Checklist
README.md__tests__folder