fix: Handle hex colors that does not start with "#" or "0x". #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you check if it is needed on the newest |
|
Closing due to no response provided. Feel free to comment to reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Minor partial fix of #1740 . This PR fixes the issue with colors containing a hex value, but without the
#or0xstart.Test Plan
I have not managed to get a local version of the library to work in my test app, so could not take on the major parts of the issue.
What's required for testing (prerequisites)?
A value of
fill="888888"What are the steps to reproduce (after prerequisites)?
Render the SVG with the color.
Compatibility
Checklist
README.md__tests__folder