-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for setting an onError prop on SvgCssUri #1718
Conversation
Also, could you add a test example in |
Is it ready to be merged in your opinion @SjaakSchilperoort ? |
I looked into adding example code in |
If it is possible, I would opt for including both documentation and a test in |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉 Thanks for your contribution!
Summary
In PR #1266, support was added for setting an
onError
property onSvgUri
. This PR adds the same toSvgCssUri
.Test Plan
This should now work:
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md
__tests__
folderNote
This PR is on request from @WoLewicki in PR #1503.