Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web example #1717

Merged
merged 6 commits into from
Mar 7, 2022
Merged

Add web example #1717

merged 6 commits into from
Mar 7, 2022

Conversation

zoontek
Copy link
Contributor

@zoontek zoontek commented Mar 4, 2022

Screenshot 2022-03-04 at 13 35 38

Summary

Following #1294

I tried to keep the changes as minimal as possible, but I had to:

  • Remove gradle from .gitignore (not supposed to be here)
  • Add jsxBracketSameLine until prettier is updated (the current version does not support it, it clashes with prettier-eslint and it's impossible to work)
  • Delete custom Modal (now included in react-native-web)
  • Lint the codebase
  • Fix some typescript errors
  • Move getHasTouchableProperty to the web implem (it's only used here) + remove any
  • Delete SnackImageCompat (doesn't work at all, use inheritance other composition, results in a Super expression must either be null or a function error)

Screenshot 2022-03-04 at 13 15 45

And as mentioned in the original PR:

  • The PanResponder example does not work:

Screenshot 2022-03-04 at 13 44 46

  • The focus issue is sure fixed, but pressability just don't work anymore on web:

Screenshot 2022-03-04 at 13 34 50

Screen.Recording.2022-03-04.at.13.20.25.mov

Checklist

  • I have tested this on a device and a simulator
  • I added documentation in README.md
  • I updated the typed files (typescript)
  • I added a test for the API in the __tests__ folder

Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments, please answer them and I think we can merge it then. Thanks for your contribution 🎉

src/ReactNativeSVG.web.ts Outdated Show resolved Hide resolved
Example/src/examples/Image.tsx Show resolved Hide resolved
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@WoLewicki WoLewicki merged commit 2fa9645 into software-mansion:main Mar 7, 2022
@zoontek zoontek deleted the add-web-example branch March 7, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants