-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows support #1632
Add Windows support #1632
Conversation
Any updates on this? |
@PPatBoyd @marlenecota can this be merged? @marlenecota you mentioned a parity document, was wondering if I missed this? |
Did anybody try to merge this? |
Guys, please let me know what is this issue up to? I can contribute by testing and debugging. |
@msand We've tested this too. Is there anything we can further do to help expedite a merge? |
Add windows to "files" and "keywords"
I'd also like to know what the status here is - is there anything folks can do to help out with this? |
Text, TSpan, TextPath, ClipPath, Mask, Marker, and ForeignObject have been put on the back burner, but this could be merged as is for a partial implementation. Need someone with write access to be ok with that and approve it. |
@marlenecota I'm seeing this when trying to build for ARM64 I tried running NuGet package restore but still get the same error. Any idea what I might be missing? |
@Saadnajmi @asklar @PPatBoyd sorry to be annoying, but would it be possible to take a peak at this? Even this partial implementation would be a huge boon for me and it looks like many others. @marlenecota thanks for all of the hard work! |
Software Mansion maintains React Native SVG now, so I think the person who could comment on whether this pointed up with their future plans for the repo is @WoLewicki . I know they were working on bringing Fabric support. |
I have almost no knowledge of Windows development so if you feel like it is ready to be merged, I am OK with that and we can do it for sure. We are working on bringing Fabric to the repo, but I am also maintainer of |
@marlenecota it seems it could be merged back? |
Tested here too. Please. It’s ready. |
ready to merge? |
@jdk - which version of RN/RNW did you test? This was created and tested in 0.64. I am currently spread too thin with other work to validate newer versions. If anyone has been able to validate this change against newer versions or can volunteer time to do so, please report results back on this thread. If we want to go ahead with the merge, any upgrading issues could be addressed in future PRs. |
"react-native": "0.67.4", |
Working on: If we could please get this merged 🙏🏻 |
@marlenecota if you are OK with merging it, we can do it and then release a new version of library so people can test it thoroughly. |
When can we expect this to merge and release? |
@WoLewicki sounds good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Let's merge it 🚀
for (size_t i = 0; i < stops.size(); ++i) { | ||
Brushes::CanvasGradientStop stop{}; | ||
stop.Position = Utils::JSValueAsFloat(stops.at(i)); | ||
stop.Color = Utils::JSValueAsColor(stops.at(++i)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So since #1726 was merged, it should work correctly then @marlenecota ?
Adds Windows support. Co-authored-by: Adam Gleitman <[email protected]> Co-authored-by: REDMOND\agnel <[email protected]>
Thank you @WoLewicki ! I'm sure this will make a lot of people happy and their lives easier working across platforms=) |
Summary
Explain the motivation for making this change: here are some points to help you:
support macos & windows #297
Please add support for react-native-macos and react-native-windows. #1426
may react-native-svg could support for react native windows? #1610
Adding support for react-native-windows.
Done: Svg, Rect, Circle, Ellipse, Line, Polygon, Polyline, Path, G, Use, Symbol, Defs, Image, LinearGradient, RadialGradient, Pattern
Partial: Text, TSpan
Missing: TextPath, ClipPath, Mask, Marker, ForeignObject.
Using Win2D
Test Plan
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
SvgDemo_Part1.mp4
SvgDemo_Part2.mp4
Compatibility
Checklist
README.md
__tests__
folder