Update TypeScript Definition #1575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
XI1498-KaranKalsi
suggested changes
Jul 16, 2021
| @@ -416,8 +427,7 @@ export interface TSpanProps extends CommonPathProps, FontProps { | |||
| rotate?: NumberArray; | |||
| inlineSize?: NumberProp; | |||
| } | |||
| export const TSpan: React.ComponentClass<TSpanProps>; | |||
| export type TSpan = React.ComponentClass<TSpanProps>; | |||
| export class TSpan extends Shape<TSPanProps>{} | |||
|
Since #1806 has been merged, I think those issues are no longer a problem as types are taken directly from components' files. I will close this PR then. Feel free to comment here if I am wrong and we can always reopen it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the type definition to expose components methods.