Xcode 12 compatibility fix #1513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fix Xcode 12 compatibility problem. Please check issue here: facebook/react-native#29633
ssssssssssss
approved these changes
Feb 7, 2021
|
This PR needs to be fixed and merged ASAP since this library doesn't work on XCode 12 without hacks. |
|
As @The0racle said, this PR needs to be merged immediately. The build in Xcode 12 does not work with this library. |
|
Can we please merge this pull request @ssssssssssss ? Its very URGENT!!! |
|
Up to date version here #1604 |
|
Since #1604 has been merged, I will close this PR. Feel free to comment if I am wrong and we can reopen it then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Latest Xcode 12 fails to build while without a module to depend on React-Core directly hence this change is necessary for all native modules on iOS. For more details please check: facebook/react-native#29633
Test Plan
Use this branch to install with an app running on Xcode 12.