Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate symbol '_distance' with MobileVLCKit #1508

Merged
merged 8 commits into from
Apr 12, 2022
Merged

duplicate symbol '_distance' with MobileVLCKit #1508

merged 8 commits into from
Apr 12, 2022

Conversation

notjulian
Copy link
Contributor

@notjulian notjulian commented Dec 17, 2020

Related: xuyuanzhou/react-native-yz-vlcplayer#68

thanks to @ilyapavkin

Summary

Explain the motivation for making this change: here are some points to help you:

  • What issues does the pull request solve?

duplicate symbol '_distance' in:
/Users/namtran/Library/Developer/Xcode/DerivedData/xxxxx-cnkfbfmejgwnrgdjwcktivwklalt/Build/Products/Debug-iphonesimulator/RNSVG/libRNSVG.a(RNSVGPathMeasure.o)
/Users/namtran/Desktop/factorynowreact/ios/Pods/MobileVLCKit/MobileVLCKit-binary/MobileVLCKit.framework/MobileVLCKit(tools.c.o)
ld: 1 duplicate symbol for architecture x86_64
clang: error: linker command failed with exit code 1

Test Plan

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added documentation in README.md
  • I updated the typed files (typescript)
  • I added a test for the API in the __tests__ folder

@notjulian
Copy link
Contributor Author

please @msand help ^_^

Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I added some comments.

package.json Outdated Show resolved Hide resolved
ios/Utils/RNSVGPathMeasure.m Outdated Show resolved Hide resolved
@WoLewicki WoLewicki changed the base branch from develop to main March 3, 2022 11:21
@notjulian
Copy link
Contributor Author

Hi @WoLewicki,
do you know when will be merged?

thank you so much

Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. LGTM 🎉 Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants