fix(android): animated stroked path with useNativeDriver: true #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirawatGG
approved these changes
Jan 14, 2020
msand
changed the title
|
Lgtm, thanks for this! |
|
🎉 This PR is included in version 11.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When animating
Pathwithdattribute andnativeDriver:true, React sometimes setsnullto the property, and it got crashed. (Still happens onRN 0.61.4andreact-native-svg 10.1.0)Animated Path d attribute #951 (comment)
Animated Path d attribute #951 (comment)
When animating
strokeon Android, the color seems to be wrong, so I modified it by copying the implementation detail fromfillTest Plan
Try animating stroke, and path, using
useNativeDriver:truehttps://gist.github.com/HelloCore/bafdf02644012bb47d85e828dd734e41
Compatibility
Checklist