-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crashing on Android #38
Comments
I have no idea about what happened here. |
I tried both versions You can use the other link's issue to see an example project that crashes in debug mode only:
If the new version doesn't use React.ART I don't know why it would still behave the same... |
We're seeing this too, random crashes due to this package. (Android only) |
+1 |
I've run into the same issue with both packages. Interesting for me it doesn't crash when debugging in Chrome, but will consistently crash when it is not. |
Clues are badly needed. Has anyone posted the crash debug info needed to help trouble-shoot this? I am afraid to invest time in using this component with this issue #38 active |
@esutton Crash logs are posted here: facebook/react-native#6760 |
Some android phones crash on a So it may be that a call to |
Can consistently reproduce with this app: https://gogs.sr.ht/SirCmpwn/sotp/src/eef40c5449ef9abe1c994d3f74232e3250293893 |
I am also getting error on Android. Here is the error report.
|
This is also crashing for me on random intervals... crashing is increased when animating. |
Here is a stack trace from an android crash. Caused by setNativeProps of the transform of a , surrounding an , this error is intermittent, and only occurs occasionally:
|
Did anyone find any solution or workaround for this issue? I am also facing it. |
+1 |
I could solve this problem for my use case. In my case, I changed my image component with, and my app is not crashing now. I don't exactly know what was the root cause of this problem, but definitely my component didn't need to be re-rendered every time. |
@ggsrivas: This seems to work for me as well. Not sure if its a long term solution though. |
Indeed. I actually animate this component as a core part of my app's functionality. |
I agree. If you need animation then this solution will not work. Actually, in my application, I also have one svg image(loading spinner) which uses animation and my app is working without crash with this component. One way of finding out which element is causing crash is to remove svg elements one by one and see if your app is still crashing or not. |
The reason might be because of this bug: facebook/fresco#1363 Memory cleanup of animated images is broken in Fresco: facebook/fresco#1363 (comment) |
I'm not sure if this ART commit is related with this problem. |
@magicismight Have you made progress on this? Our app (BlitzPick -- not yet available on Google Play, but it is available for iOS) uses react-native-svg for all of its icons, and we're having massive stability problems as we're trying to get it ready for public consumption. |
@dacarley Sorry about that,I'll get that commit merged today. |
@magicismight Sorry to harp, but have you been able to get to this? |
I'm working on it, found it's not that easy to get that commit merged into svg. |
We have changed the SvgView into a subclass from ViewGroup insteadof View for some reasons. |
Hi @magicismight, Thanks! |
@mlabrum |
@dacarley DONE. |
Thanks! We’ll upgrade shortly. On November 8, 2016 at 7:23:26 AM, Horcrux ([email protected]) wrote: @dacarley https://github.com/dacarley DONE. — |
@magicismight thank you for landing this change! Good news is, that our use case of The bad news is that it still crashes occasionally with the same error message as facebook/react-native#6760, so this does not fix the root cause of the issue.
|
Any news? It still crashes for me =( |
+1 |
+1 This still crashes randomly in v 4.4.1 against React Native 0.39.2 for what appears to be the same reasons (Fatal signal 11 (SIGSEGV) at 0x67110038 (code=2)). Much more likely to happen on views with significant SVG use. For now I have had to remove a fair amount of SVGs in the view to get the app stable-ish. I also noticed that the changes for 4.3.2 mentioned above by @magicismight had been reverted, curious as to why? FTR the crash goes away completely when when I remove all SVGs from views, until this bug is ironed out I won't be able to consider my app production ready as it makes it somewhat unstable and is now missing a fair amount of UI work. This crash never happens on the apps iOS counterpart which shares most of the js code. Just wanted to understand that if this is still a known issue that appears to be fixable? |
This is still a known issue in ReactNativeART and react-native-svg. |
Good news! |
@magicismight amazing! We'll test this ASAP. |
Awesome thank you looking forward to checking it out!
- Jesse
… On Jan 5, 2017, at 4:06 AM, Jani Eväkallio ***@***.***> wrote:
@magicismight amazing! We'll test this ASAP.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I have pushed the commits to a new branch. |
Thank you! |
4.6.0 has been released. |
I updated react-native-svg to 4.6.0 and react-native to 0.40.0 and crashes are less frequently but problem still exists. |
Anyone else experiencing crashing on Android?
Details here:
facebook/react-native#6760
The text was updated successfully, but these errors were encountered: