Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v13.3.0 incompatible with react-native <0.68.0 #1890

Closed
DrOverbuild opened this issue Oct 6, 2022 · 2 comments · Fixed by #1891
Closed

v13.3.0 incompatible with react-native <0.68.0 #1890

DrOverbuild opened this issue Oct 6, 2022 · 2 comments · Fixed by #1891

Comments

@DrOverbuild
Copy link
Contributor

Bug

Android build fails due to an unknown symbol:

./node_modules/react-native-svg/android/src/main/java/com/horcrux/svg/SvgViewManager.java:177: error: cannot find symbol
        method.invoke(view, PointerEvents.parsePointerEvents(pointerEventsStr));
                                         ^
  symbol:   method parsePointerEvents(String)
  location: class PointerEvents

The problem is SvgViewManager.java references com.facebook.react.uimanager.PointerEvents.parsePointerEvents, which, looking at the tags for the commit in which the method was introduced, is only available in React Native v0.68.0 and later.

We are currently on the latest version of react-native 0.67, and we will just revert to react-native-svg v13.2.0 until we can upgrade our project to the latest react-native. But I thought I'd let the maintainers know.

@WoLewicki
Copy link
Member

Oh, I didn't know it's such a new method 😅 I will then revert it to the old implementation and release 13.4.0 soon 🎉 Or do you want to contribute with such a PR?

@DrOverbuild
Copy link
Contributor Author

Ah yeah I would love to. 😄

DrOverbuild added a commit to DrOverbuild/react-native-svg that referenced this issue Oct 7, 2022
WoLewicki pushed a commit that referenced this issue Oct 10, 2022
Replaces PointerEvents.parsePointerEvents(pointerEventsStr) with PointerEvents.valueOf(pointerEventsStr.toUpperCase(Locale.US).replace("-", "_")). This is the implementation of the original method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants