fix(Android, Stack): Fix flex-end positioning in formSheet #3346
+169
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0maboro
force-pushed
the
@t0maboro/form-sheet-3-detents-flex-end
branch
from
2ec13af to
1b0b681
Compare
kkafar
reviewed
Nov 7, 2025
Member
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
I don't have any functional remarks. Good job on that front. But some stylistic nitpicks here 👇🏻 When we get this cleaned up, we can proceed.
Will be nitpicking here hard, but I see some code refactored & inconsistencies introduced.
Btw. if we have a small data structure for the detents we could solve this cleaner.
android/src/main/java/com/swmansion/rnscreens/bottomsheet/SheetDelegate.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/rnscreens/bottomsheet/SheetDelegate.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/rnscreens/bottomsheet/SheetDelegate.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/rnscreens/bottomsheet/SheetDelegate.kt
Outdated
Show resolved
Hide resolved
Contributor
Author
I remember about that, but unfortunately I haven't a capacity to focus on it yet https://github.com/software-mansion/react-native-screens-labs/issues/536 |
kkafar
approved these changes
Nov 7, 2025
Member
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
Looks good now. Great job. Thanks! ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using 3 detents, the size of the
formSheetis calculated based on the screen size and does not respect the detents. In this PR, I add amaxHeighttoSheetBehaviorwhen using 3 detents, ensuring the sheet respects the detent configuration. I also did a minor refactor of this variable for consistency.Note:
In the example, I'm adding more TCs for better regression testing, but only 3 detents were broken
Note:
With this PR i noticed that the formsheet doesn't respect system bars, I started working on that issue separately: #3336
Fixes https://github.com/software-mansion/react-native-screens-labs/issues/458
Changes
maxHeightfor sheetBehavior with 3 detentsScreenshots / GIFs
Here you can add screenshots / GIFs documenting your change.
You can add before / after section if you're changing some behavior.
Before
before.mov
After
after.mov
Test code and steps to reproduce
Added a new example for regression testing - with more examples than just the failing one, just in case.
Checklist