-
-
Notifications
You must be signed in to change notification settings - Fork 595
fix(iOS): modal content flicker during enter transition on iPad #3345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kkafar
wants to merge
4
commits into
main
Choose a base branch
from
@kkafar/spf-layout-issue-ios
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| import React from 'react'; | ||
| import { View, Button } from 'react-native'; | ||
| import { NavigationContainer } from '@react-navigation/native'; | ||
| import { createNativeStackNavigator } from '@react-navigation/native-stack'; | ||
|
|
||
| const Stack = createNativeStackNavigator(); | ||
|
|
||
| function HomeScreen({ navigation }) { | ||
| return ( | ||
| // In original repro SafeAreaView from `react-native` has been used here. | ||
| <View style={{ flex: 1, justifyContent: 'center', alignItems: 'center' }}> | ||
| <Button | ||
| title="Open Modal" | ||
| onPress={() => navigation.navigate('Modal')} | ||
| /> | ||
| </View> | ||
| ); | ||
| } | ||
|
|
||
| function ModalScreen() { | ||
| const onLayout = (event) => { | ||
| const { width } = event.nativeEvent.layout; | ||
| console.log('Modal width:', width); | ||
| }; | ||
| return ( | ||
| <View style={{ flex: 1, width: '100%', alignSelf: 'center', paddingHorizontal: 16, backgroundColor: 'green' }} onLayout={onLayout}> | ||
| <View style={{ flex: 1, backgroundColor: 'purple' }} /> | ||
| </View> | ||
| ); | ||
| } | ||
|
|
||
| function App() { | ||
| return ( | ||
| <NavigationContainer> | ||
| <Stack.Navigator> | ||
| <Stack.Screen name="Home" component={HomeScreen} /> | ||
| <Stack.Screen | ||
| name="Modal" | ||
| component={ModalScreen} | ||
| options={{ | ||
| presentation: 'modal' | ||
| }} | ||
| /> | ||
| </Stack.Navigator> | ||
| </NavigationContainer> | ||
| ); | ||
| } | ||
|
|
||
| export default App; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -1464,6 +1464,14 @@ - (void)updateLayoutMetrics:(const react::LayoutMetrics &)layoutMetrics | |||||
| _newLayoutMetrics = layoutMetrics; | ||||||
| _oldLayoutMetrics = oldLayoutMetrics; | ||||||
| UIViewController *parentVC = self.reactViewController.parentViewController; | ||||||
|
|
||||||
| if (parentVC == nil && [self isKindOfClass:RNSModalScreen.class]) { | ||||||
| // If we're in modal presentation, we don't want to set the frame from RN, | ||||||
| // as the available space is most likely restriced & differs from what Yoga | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| // resolves during firt layout. We want to rely on native layout here. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| return; | ||||||
| } | ||||||
|
|
||||||
| if (parentVC == nil || ![parentVC isKindOfClass:[RNSNavigationController class]]) { | ||||||
| [super updateLayoutMetrics:layoutMetrics oldLayoutMetrics:oldLayoutMetrics]; | ||||||
| } | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: I'd move this a few lines above, closer to other numbered tests.