Skip to content

Conversation

@kligarski
Copy link
Contributor

@kligarski kligarski commented Oct 27, 2025

Description

Adds support for tabBarHidden prop in TabsHost.

Screen_recording_20251027_124939.mp4

Changes

  • handle tabBarHidden prop on Android
  • update SAV interface insets on tab bar visibility change

Test code and steps to reproduce

Run TestBottomTabs, add tabBarHidden prop, observe dynamic changes.

Checklist

Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One remark. Overall looks good. Thank you.

Base automatically changed from @kligarski/ios-hide-tab-bar to main November 3, 2025 06:28
@kligarski kligarski force-pushed the @kligarski/android-hide-tab-bar branch from 0e5a4dd to abe2006 Compare November 3, 2025 08:37
@kligarski kligarski requested a review from kkafar November 3, 2025 08:38
Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you

@kligarski kligarski merged commit 926c361 into main Nov 3, 2025
5 checks passed
@kligarski kligarski deleted the @kligarski/android-hide-tab-bar branch November 3, 2025 11:11
t0maboro pushed a commit that referenced this pull request Nov 3, 2025
## Description

Adds support for `tabBarHidden` prop in `TabsHost`.


https://github.com/user-attachments/assets/35fccc4b-e457-4f53-9a1a-17c3ee188fba

## Changes

- handle `tabBarHidden` prop on Android
- update SAV interface insets on tab bar visibility change

## Test code and steps to reproduce

Run `TestBottomTabs`, add `tabBarHidden` prop, observe dynamic changes.

## Checklist

- [x] Included code example that can be used to test this change
- [x] Updated TS types
- [x] Updated documentation: <!-- For adding new props to native-stack
-->
- [ ]
https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md
- [ ]
https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md
- [ ]
https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx
- [ ]
https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx
- [x] Ensured that CI passes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants