-
-
Notifications
You must be signed in to change notification settings - Fork 595
feat(Android, Tabs): add prop to hide the tab bar #3344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0maboro
reviewed
Oct 27, 2025
android/src/main/java/com/swmansion/rnscreens/gamma/tabs/TabsHostAppearanceApplicator.kt
Outdated
Show resolved
Hide resolved
t0maboro
approved these changes
Oct 27, 2025
kkafar
requested changes
Oct 29, 2025
Member
kkafar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One remark. Overall looks good. Thank you.
android/src/main/java/com/swmansion/rnscreens/gamma/tabs/TabsHost.kt
Outdated
Show resolved
Hide resolved
0e5a4dd to
abe2006
Compare
kkafar
approved these changes
Nov 3, 2025
Member
kkafar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you
t0maboro
pushed a commit
that referenced
this pull request
Nov 3, 2025
## Description Adds support for `tabBarHidden` prop in `TabsHost`. https://github.com/user-attachments/assets/35fccc4b-e457-4f53-9a1a-17c3ee188fba ## Changes - handle `tabBarHidden` prop on Android - update SAV interface insets on tab bar visibility change ## Test code and steps to reproduce Run `TestBottomTabs`, add `tabBarHidden` prop, observe dynamic changes. ## Checklist - [x] Included code example that can be used to test this change - [x] Updated TS types - [x] Updated documentation: <!-- For adding new props to native-stack --> - [ ] https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx - [x] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for
tabBarHiddenprop inTabsHost.Screen_recording_20251027_124939.mp4
Changes
tabBarHiddenprop on AndroidTest code and steps to reproduce
Run
TestBottomTabs, addtabBarHiddenprop, observe dynamic changes.Checklist