Skip to content

fix(android): crash while drawing in dispatchGetDisplayList #3322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(android): crash while drawing in dispatchGetDisplayList #3322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions android/src/main/java/com/swmansion/rnscreens/stack/anim/ScreensAnimation.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,12 @@ internal class ScreensAnimation(
t: Transformation,
) {
super.applyTransformation(interpolatedTime, t)
// interpolated time should be the progress of the current transition
mFragment.dispatchTransitionProgressEvent(interpolatedTime, !mFragment.isResumed)
// This is called while android is drawing. The event might be intercepted by reanimated
// which could trigger a sync mount, which can alter the native view hierarchy, which
// could lead to a crash, see: https://github.com/software-mansion/react-native-screens/issues/3321
mFragment.view?.post {
// interpolated time should be the progress of the current transition
mFragment.dispatchTransitionProgressEvent(interpolatedTime, !mFragment.isResumed)
}
}
}