refactor(iOS): rename label -> title in context of header items API
#3318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
requested review from
kligarski,
kmichalikk and
t0maboro
and removed request for
t0maboro
kmichalikk
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intends to align back prop naming with the platform
nomenclature.
The header item API is iOS specific and there is really no reason to obfuscate in any way
what we expose.
Changes
Renamed
label->title&labelStyle->titleStyle.I recognize that technically this is a breaking change, however since react-navigation
has not published the API yet, and we're in coordination, API end-users won't be affected.
Test code and steps to reproduce
BarButtonItemsexample should work the same.Checklist