Skip to content

feat: add snapshotAfterUpdates property to RNSScreenView #3296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 4, 2025
Merged

feat: add snapshotAfterUpdates property to RNSScreenView #3296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f37ffd3
add snapshotAfterUpdates
bartlomiejbloniarz Oct 15, 2025
3eb252f
Just read it from the screenView
bartlomiejbloniarz Nov 4, 2025
613d0cf
Merge branch 'main' into @bartlomiejbloniarz/add-set-snapshot-after-u…
kkafar Nov 4, 2025
cee931e
Add comment that this property was added for the sake of reanimated
kkafar Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ios/RNSScreen.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,12 @@ namespace react = facebook::react;
@property (nonatomic, readonly) BOOL hasHeaderConfig;
@property (nonatomic, readonly, getter=isMarkedForUnmountInCurrentTransaction)
BOOL markedForUnmountInCurrentTransaction;

/**
* Whether the snapshot for the transition made for JS-popped views should be taken after view updates or not.
* *This property was introduced for the sake of integration with reanimated.*
*/
@property (nonatomic) BOOL snapshotAfterUpdates;
#else
@property (nonatomic, copy) RCTDirectEventBlock onAppear;
@property (nonatomic, copy) RCTDirectEventBlock onDisappear;
Expand Down
4 changes: 3 additions & 1 deletion ios/RNSScreen.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ - (instancetype)initWithFrame:(CGRect)frame
{
if (self = [super initWithFrame:frame]) {
static const auto defaultProps = std::make_shared<const react::RNSScreenProps>();
_snapshotAfterUpdates = NO;
_props = defaultProps;
_reactSubviews = [NSMutableArray new];
_contentWrapperBox = {};
Expand Down Expand Up @@ -2162,7 +2163,8 @@ - (void)setViewToSnapshot
UIView *superView = self.view.superview;
// if we dismissed the view natively, it will already be detached from view hierarchy
if (self.view.window != nil) {
UIView *snapshot = [self.view snapshotViewAfterScreenUpdates:NO];
auto afterUpdates = self.screenView.snapshotAfterUpdates;
UIView *snapshot = [self.view snapshotViewAfterScreenUpdates:afterUpdates];
snapshot.frame = self.view.frame;
[self.view removeFromSuperview];
self.view = snapshot;
Expand Down
Loading