Skip to content

fix(iOS): prevent back button icon from "jumping" during pop animation when display mode minimal is set #2800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 28, 2025
Merged

fix(iOS): prevent back button icon from "jumping" during pop animation when display mode minimal is set #2800

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9beb18
Hide the back button title using display mode
kkafar Mar 24, 2025
b49dd22
chore: update docs
maciekstosio Mar 25, 2025
8fa3316
Update guides/GUIDE_FOR_LIBRARY_AUTHORS.md
maciekstosio Mar 26, 2025
752ca27
chore: add changes from comments
maciekstosio Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions ios/RNSScreenStackHeaderConfig.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,12 +631,9 @@ + (void)updateViewController:(UIViewController *)vc

auto shouldUseCustomBackBarButtonItem = !isBackTitleBlank || config.disableBackButtonMenu;

#if defined(__IPHONE_OS_VERSION_MAX_ALLOWED) && defined(__IPHONE_14_0) && \
__IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_14_0
if (@available(iOS 14.0, *)) {
prevItem.backButtonDisplayMode = config.backButtonDisplayMode;
}
#endif
// This has any effect only in case the `backBarButtonItem` is not set.
// We apply it before we configure the back item, because it might get overriden.
prevItem.backButtonDisplayMode = config.backButtonDisplayMode;
Copy link
Member Author

@kkafar kkafar Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to wrap it inside ifdefs due to #2799 (min supported iOS version is 15.1 now


if (config.isBackTitleVisible) {
if ((config.backTitleFontFamily &&
Expand Down Expand Up @@ -666,11 +663,9 @@ + (void)updateViewController:(UIViewController *)vc
// back button title should be not visible next to back button,
// but it should still appear in back menu (if one is enabled)

// When backBarButtonItem's title is null, back menu will use value
// of backButtonTitle
[backBarButtonItem setTitle:nil];
shouldUseCustomBackBarButtonItem = YES;
prevItem.backButtonTitle = resolvedBackTitle;
prevItem.backButtonDisplayMode = UINavigationItemBackButtonDisplayModeMinimal;
shouldUseCustomBackBarButtonItem = NO;
}

// Prevent unnecessary assignment of backBarButtonItem if it is not customized,
Expand Down
Loading