fix: make unstable_sheetFooter usable with react-navigation v7 #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Associated PR:
react-native-screensreact-navigation/react-navigation#12258The footer is currently broken, as in the effect of recent refactors it erroneously ended up being rendered as child as
ScreenStackItem, thus due to internal implementation it is rendered underScreenContentWrapper. However, it has to be rendered as direct child ofScreencomponent (the same asHeaderConfig).Under usual circumstances this would be a breaking change, however the prop is marked as
unstable, therefore I'm proceeding.Changes
unstable_sheetFooteris now rendered byScreenStackItem.Test code and steps to reproduce
Test1649Checklist