Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rebuild TVOSExample with RN 0.76 #2486

Merged
merged 3 commits into from
Nov 13, 2024
Merged

chore: rebuild TVOSExample with RN 0.76 #2486

merged 3 commits into from
Nov 13, 2024

Conversation

alduzy
Copy link
Member

@alduzy alduzy commented Nov 8, 2024

Description

This PR rebuilds TVOSExample with version 0.76 of react-native and without expo using the template.

Checklist

  • Ensured that CI passes

@alduzy alduzy requested review from kkafar and WoLewicki November 8, 2024 11:30
Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you made sure that this actually opens TV os app and not just iOS one? :D

  • I think we can remove all Android code, right? (separate PR)

.github/workflows/tv-os-build-test.yml Show resolved Hide resolved
TVOSExample/android/app/build.gradle Show resolved Hide resolved
TVOSExample/package.json Show resolved Hide resolved
TVOSExample/package.json Show resolved Hide resolved
@alduzy
Copy link
Member Author

alduzy commented Nov 13, 2024

@kkafar I tested it on Apple TV simulator and it works just fine. I wouldn't remove the android directory as it's created by default by the template.

@alduzy alduzy requested a review from kkafar November 13, 2024 15:29
Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okie dokie, we're looking good. Thanks!

@alduzy alduzy merged commit c0caddb into main Nov 13, 2024
2 checks passed
@alduzy alduzy deleted the @alduzy/tvos-0.76-bump branch November 13, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants