fix(Android): title invisible with searchbar enabled #2456
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes title being invisible when searchbar is enabled.
In #2395 I added
alignItems: 'center'
style to the header config component. It aimed to fix iOS subviews floating mid-screen when a larger subview is provided:alignItems: 'center'
alignItems: 'center'
This change unintentionally introduced a regression on Android. When searchabar is enabled, the
ScreenStackHeaderConfig
components height is equal 0 and it does not 'stretch' to accomodate the native title. Simple solution is to center align the subviews depending on the Platform.alignItems: 'center'
alignItems: 'center'
Changes
Test2395.tsx
reproTest code and steps to reproduce
Test2395.tsx
reproChecklist