fix: align units of sheet corner radius in different callsites #2378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
force-pushed
the
@kkafar/align-corner-radius-values
branch
from
093c896 to
3e16e65
Compare
|
Approved here: #2377 (comment) Could not reopen that PR, hece new one. |
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
…are-mansion#2378) ## Description Before this PR, when updating corner size after initial render different unit (pixel) has been used opposed to `dp` used during initial render. This PR align this behaviour so that `dp` is always used. ## Changes * Calculate appropriate value in `Screen.onSheetDetentChange` function ## Test code and steps to reproduce `Test1649` ## Checklist - [x] Included code example that can be used to test this change - [ ] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this PR, when updating corner size after initial render different unit (pixel) has been used opposed to
dpused during initial render. This PR align this behaviour so thatdpis always used.Changes
Screen.onSheetDetentChangefunctionTest code and steps to reproduce
Test1649Checklist