feat: add monorepo support for Android builds #2352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
## Description Based on: software-mansion#2337 by @morganick. Please see the original PR and its description for details. See: software-mansion#2337 (review) for discussion why new PR has been created. ## Changes - **Using node resolver to find react native package for better monorepo support** - **Using rootDir instead of projectDir** - **Change the order of path lookup** ## Test code and steps to reproduce I've tested it using our both example apps and additionally I've created fresh RN app and tested the Android build there. ## Checklist - [x] Ensured that CI passes --------- Co-authored-by: Nick Morgan <[email protected]>
kkafar
added a commit
that referenced
this pull request
Oct 25, 2024
## Description Based on: #2337 by @morganick. Please see the original PR and its description for details. See: #2337 (review) for discussion why new PR has been created. ## Changes - **Using node resolver to find react native package for better monorepo support** - **Using rootDir instead of projectDir** - **Change the order of path lookup** ## Test code and steps to reproduce I've tested it using our both example apps and additionally I've created fresh RN app and tested the Android build there. ## Checklist - [x] Ensured that CI passes --------- Co-authored-by: Nick Morgan <[email protected]> (cherry picked from commit 408112a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on: #2337 by @morganick.
Please see the original PR and its description for details.
See: #2337 (review)
for discussion why new PR has been created.
Changes
Test code and steps to reproduce
I've tested it using our both example apps and additionally I've created fresh RN app
and tested the Android build there.
Checklist