-
-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added missing icon and launch screen to fabric example #2268
Conversation
Great change! Just leaving one suggestion here. For reference, I'm also leaving links for reanimated logos: |
I've replaced the icon on fabric as @tboba suggested 😉 |
Murarz tynkarz akrobata Nice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A load of new kilobytes for our repository (that hurts me), but fine :D 🟢
…-mansion#2268) ## Description This PR adds missing icon and launch screen to `FabricExample` app. After copying the icons from paper example i noticed there are icons for iPad and the example itself supports iPad platform. Thus I decided to add the iPad support to fabric example as well. ## Changes - added iOS icons and launch screen - added iPad support - added android icons and launch screen ## Screenshots / GIFs ### Before ![Screenshot 2024-07-30 at 11 13 17](https://github.com/user-attachments/assets/791dd46d-7e4a-4e54-bcfa-20893255dfe3) ![Screenshot 2024-07-30 at 11 15 08](https://github.com/user-attachments/assets/98c9d114-270c-4ccf-b876-b7215ee70a43) ### After ![Screenshot 2024-07-30 at 13 20 29](https://github.com/user-attachments/assets/c1c29c73-fd5b-4f33-820d-424fea6fdf15) ![Screenshot 2024-07-30 at 12 54 53](https://github.com/user-attachments/assets/1d033532-4d5b-465d-9289-19da50674013) ## Checklist - [x] Ensured that CI passes
Description
This PR adds missing icon and launch screen to
FabricExample
app.After copying the icons from paper example i noticed there are icons for iPad and the example itself supports iPad platform. Thus I decided to add the iPad support to fabric example as well.
Changes
Screenshots / GIFs
Before
After
Checklist