feat: common compatibility source for docs and CI #8004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skusnierz
requested review from
kmagiera,
piaskowyk and
tomekzaw
as code owners
## Summary This issue was introduced in the #7784 PR and was caused by the `getDouble()` call on the `folly::dynamic` value. I assumed that all values that come from JS are double (since this is how JS represents all numbers) but, in fact, the value was stored as the 64-bit integer in the `folly::dynamic` and the `.getDouble()` call caused crashes. To fix the issue, I decided to use the safer method `.asInt`, which will convert the number to the integer type (if it is not already an int) instead of throwing error. I also changed the `double` constructor to the `int64_t` constructor as the integer type is more correct than the `double` type. ## Example recording ### Before https://github.com/user-attachments/assets/6b5dc444-7049-4687-a36d-55dd7c9f33ac ### After https://github.com/user-attachments/assets/d9c22957-ba62-41ab-897f-8e31ebac90c0 ## Test plan Open the `Transitions -> Test Examples -> Playground` example and press on the **Change state** button a few times in a row.
skusnierz
added
the
Check compatibility
tjzel
reviewed
Aug 12, 2025
Collaborator
tjzel
left a comment
tjzel
left a comment
There was a problem hiding this comment.
Clean up stuff and we gucci 👌
.github/actions/reanimated-compatibility-check-build/action.yml
Outdated
Show resolved
Hide resolved
.github/actions/reanimated-compatibility-check-build/action.yml
Outdated
Show resolved
Hide resolved
.github/actions/reanimated-compatibility-check-build/action.yml
Outdated
Show resolved
Hide resolved
.github/actions/reanimated-compatibility-check-build/action.yml
Outdated
Show resolved
Hide resolved
skusnierz
force-pushed
the
@skusnierz/common-compatibility-json
branch
from
6e00ba4 to
f944f6b
Compare
tjzel
approved these changes
Aug 13, 2025
Collaborator
tjzel
left a comment
tjzel
left a comment
There was a problem hiding this comment.
Make sure to clean that up and we should be gucci
MatiPl01
added a commit
that referenced
this pull request
Aug 13, 2025
## Summary This PR adds a `compatibility.json` file, which stores the supported RN versions used during CI builds and on the `Compatibility Table` documentation page. ## Test plan <img width="870" height="817" alt="image" src="https://github.com/user-attachments/assets/7994b410-b055-47ad-b303-9467066e40c8" /> --------- Co-authored-by: Mateusz Łopaciński <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 20, 2025
## Summary This PR changes the way compatible versions of React Native with Reanimated are checked. fyi: In the previous PR (#8004), I added a single file where we store compatible versions of React Native with Reanimated. ## Test plan Build `fabric example` with different version of Reanimated and RN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a
compatibility.jsonfile, which stores the supported RN versions used during CI builds and on theCompatibility Tabledocumentation page.Test plan