Set compile options using target_compile_reactnative_options from react-native-flags.cmake
#7776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
changed the title
target_compile_reactnative_options from react-native-flags.cmake
piaskowyk
approved these changes
Jul 11, 2025
tjzel
approved these changes
Jul 11, 2025
jakex7
added a commit
to software-mansion/react-native-svg
that referenced
this pull request
Jul 14, 2025
…2710) # Summary PR based on software-mansion/react-native-reanimated#7776 by @tomekzaw. To support `[email protected]`, we need to include `RN_SERIALIZABLE_STATE`. This can be done using `target_compile_reactnative_options`, which sets the necessary flags and definitions automatically, instead of setting them manually. ## Test Plan CI is green and `tests-example` compiles on `[email protected]`.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 16, 2025
## Summary Work in progress. If you're getting `TypeError: (0 , _util.styleText) is not a function` during `yarn start`, please use Node.js 20 instead by running `nvm use 20`. `RN_SERIALIZABLE_STATE`: https://github.com/facebook/react-native/pulls?q=sort%3Aupdated-desc+is%3Apr+rn_serializable_state+is%3Aclosed * Merged separately in #7776 ## Test plan || Fabric (iOS) | Fabric (Android) | Web | MacOS | TVOS (iOS) | TVOS (Android) | |-|-|-|-|-|-|-| | Builds | ✅ | ✅ | ✅ | not upgraded | ✅ (not upgraded) | ✅ (not upgraded) | Runs | ✅ | ✅ | ✅ | not upgraded | ✅ (not upgraded) | ✅ (not upgraded) --------- Co-authored-by: Mateusz Łopaciński <[email protected]> Co-authored-by: Sebastian Kuśnierz <[email protected]>
skusnierz
pushed a commit
that referenced
this pull request
Sep 30, 2025
…react-native-flags.cmake` (#7776) ## Summary This PR includes `react-native-flags.cmake`and calls `target_compile_reactnative_options` in CMakeLists.txt which sets necessary flags and definitions instead of setting them manually. ## Test plan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes
react-native-flags.cmakeand callstarget_compile_reactnative_optionsin CMakeLists.txt which sets necessary flags and definitions instead of setting them manually.Test plan