-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix: separate implementation for custom errors #7390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,33 @@ | ||
| /* eslint-disable reanimated/use-reanimated-error */ | ||
| 'use strict'; | ||
|
|
||
| import { createCustomError, registerCustomError } from 'react-native-worklets'; | ||
|
|
||
| export const ReanimatedError = createCustomError('Reanimated'); | ||
|
|
||
| const ReanimatedErrorConstructor = ReanimatedError; | ||
| function ReanimatedErrorConstructor(message: string): ReanimatedError { | ||
| 'worklet'; | ||
| const prefix = '[Reanimated]'; | ||
| const errorInstance = new Error(message ? `${prefix} ${message}` : prefix); | ||
| errorInstance.name = 'ReanimatedError'; | ||
| return errorInstance as ReanimatedError; | ||
| } | ||
|
|
||
| /** | ||
| * Registers ReanimatedError in the global scope. Register only for Worklet | ||
| * runtimes. | ||
| */ | ||
| export function registerReanimatedError() { | ||
| 'worklet'; | ||
| registerCustomError(ReanimatedErrorConstructor, 'Reanimated'); | ||
| if (globalThis._WORKLET) { | ||
| globalThis.ReanimatedError = | ||
| ReanimatedErrorConstructor as IReanimatedErrorConstructor; | ||
| } | ||
| } | ||
|
|
||
| export const ReanimatedError = | ||
| ReanimatedErrorConstructor as IReanimatedErrorConstructor; | ||
|
|
||
| export interface IReanimatedErrorConstructor extends Error { | ||
| new (message?: string): ReanimatedError; | ||
| (message?: string): ReanimatedError; | ||
| readonly prototype: ReanimatedError; | ||
| } | ||
|
|
||
| export type ReanimatedError = Error & { name: 'Reanimated' }; // signed type |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,33 @@ | ||
| /* eslint-disable reanimated/use-worklets-error */ | ||
| 'use strict'; | ||
|
|
||
| import { createCustomError, registerCustomError } from './errors'; | ||
|
|
||
| export const WorkletsError = createCustomError('Worklets'); | ||
|
|
||
| // To capture it in a the registering worklet's closure. | ||
| const WorkletsErrorConstructor = WorkletsError; | ||
| function WorkletsErrorConstructor(message?: string): WorkletsError { | ||
| 'worklet'; | ||
| const prefix = '[Worklets]'; | ||
| const errorInstance = new Error(message ? `${prefix} ${message}` : prefix); | ||
| errorInstance.name = `{prefix}Error`; | ||
| return errorInstance as WorkletsError; | ||
| } | ||
|
|
||
| /** | ||
| * Registers WorkletsError in the global scope. Register only for Worklet | ||
| * runtimes. | ||
| */ | ||
| export function registerWorkletsError() { | ||
| 'worklet'; | ||
| registerCustomError(WorkletsErrorConstructor, 'Worklets'); | ||
| if (globalThis._WORKLET) { | ||
| globalThis.WorkletsError = | ||
| WorkletsErrorConstructor as IWorkletsErrorConstructor; | ||
| } | ||
| } | ||
|
|
||
| export const WorkletsError = | ||
| WorkletsErrorConstructor as IWorkletsErrorConstructor; | ||
|
|
||
| export type WorkletsError = Error & { name: 'Worklets' }; // signed type | ||
|
|
||
| export interface IWorkletsErrorConstructor extends Error { | ||
| new (message?: string): WorkletsError; | ||
| (message?: string): WorkletsError; | ||
| readonly prototype: WorkletsError; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.