-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Custom Shadow Nodes #7380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Shadow Nodes #7380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very well. I left just a few comments.
...e-reanimated/Common/NativeView/react/renderer/components/rnreanimated/ComponentDescriptors.h
Outdated
Show resolved
Hide resolved
...t-native-reanimated/Common/NativeView/react/renderer/components/rnreanimated/ShadowNodes.cpp
Outdated
Show resolved
Hide resolved
...t-native-reanimated/Common/NativeView/react/renderer/components/rnreanimated/ShadowNodes.cpp
Outdated
Show resolved
Hide resolved
...act-native-reanimated/Common/NativeView/react/renderer/components/rnreanimated/ShadowNodes.h
Outdated
Show resolved
Hide resolved
...es/react-native-reanimated/Common/NativeView/react/renderer/components/rnreanimated/States.h
Show resolved
Hide resolved
packages/react-native-reanimated/apple/reanimated/apple/view/ReanimatedView.mm
Outdated
Show resolved
Hide resolved
|
I'd like to review this PR once the above comments are addressed. |
...e-reanimated/Common/NativeView/react/renderer/components/rnreanimated/ComponentDescriptors.h
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/apple/reanimated/apple/view/ReanimatedView.mm
Show resolved
Hide resolved
MatiPl01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please address @tomekzaw comments and should be good to go. 🚀
## Summary We currently don't use the Native View because we're still experimenting with replacing commit hooks, etc. With @MatiPl01, we've decided to remove those changes from the main branch for now because they are causing some issues. We'll move them later to a branch with the experimental implementation of `display: content`. Related PRs: - #7366 - #7380 ## Test plan See at CI
Summary
This PR introduces a common implementation of custom shadow nodes for both Android and iOS. It's part of the migration towards using
display: content.Test plan
Example code